Add IsTrimmable and IsAotCompatible project attributes#188
Merged
Conversation
|
I really love this PR and want to know when will ExCSS release a new version (or even a prerelease version) to NuGet to include this AOT support. |
Owner
|
Latest is pushed to NuGet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These attributes should help finding potential incompatibilities with PublishTrimmed or PublishAot applications.
Specifically in my case I got this error (while having warnings as erros enabled):
There are multiple ways to fix this issue, and it's possible to keep Activator.CreateInstance usage, or add lambda methods in the dictionary. But I though this method is simple enough to just use if-tree instead of dictionary